feat(vucm): add integration with NI-cDAQ #19
+355
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnovatorov
reviewed
Feb 25, 2025
There was a problem hiding this comment.
Hi @anataty, thanks for your PR!
To check if linters are satisfied please run make lint locally.
anataty
force-pushed
the
ty/ni-daq/0
branch
3 times, most recently
from
28834b8 to
e6e43f4
Compare
anataty
force-pushed
the
ty/ni-daq/0
branch
2 times, most recently
from
1122fc1 to
dbc3f10
Compare
rnovatorov
reviewed
Jul 11, 2025
examples/vucm/ni-daq/script.py
Outdated
| asyncio.create_task(self.handle_conn(conn, addr)) | ||
|
|
||
| async def handle_conn(self, conn, addr): | ||
| print(addr, "accept") |
There was a problem hiding this comment.
To make this debugging info available in the Cloud you could use built-in logging capabilities via self.log.
examples/vucm/ni-daq/script.py
Outdated
| sock = self.socket | ||
| while True: | ||
| (conn, addr) = await asyncio.get_event_loop().sock_accept(sock) | ||
| asyncio.create_task(self.handle_conn(conn, addr)) |
There was a problem hiding this comment.
Should a task fail, the exception will be lost as no one is supervising it. Using a task group solves the issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.